Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output tracing resolving #29473

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 28, 2021

Follow-up to #29341 this updates to not mimic the externals resolving since we need to resolve non-external modules as well, this also makes sure we don't include transpiled files un-necessarily as they are output in webpack chunks and included in the trace that way.

This also adds a NEXT_SKIP_ISOLATE test env option to allow skipping creating an isolated Next.js install when running tests locally.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 28, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review September 28, 2021 21:46
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Sep 29, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/trace-resolving Change
buildDuration 14.5s 14.8s ⚠️ +251ms
buildDurationCached 3.7s 3.7s -10ms
nodeModulesSize 181 MB 181 MB -2.79 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/trace-resolving Change
/ failed reqs 0 0
/ total time (seconds) 3.19 3.134 -0.06
/ avg req/sec 783.58 797.6 +14.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.517 1.571 ⚠️ +0.05
/error-in-render avg req/sec 1648.44 1591.09 ⚠️ -57.35
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/trace-resolving Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/trace-resolving Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/trace-resolving Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/trace-resolving Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/trace-resolving Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/trace-resolving Change
buildDuration 7.6s 7.5s -34ms
buildDurationCached 3.7s 3.6s -85ms
nodeModulesSize 181 MB 181 MB -2.79 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/trace-resolving Change
/ failed reqs 0 0
/ total time (seconds) 3.164 3.202 ⚠️ +0.04
/ avg req/sec 790.12 780.68 ⚠️ -9.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.579 1.545 -0.03
/error-in-render avg req/sec 1583.67 1617.71 +34.04
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/trace-resolving Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/trace-resolving Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/trace-resolving Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/trace-resolving Change
_buildManifest.js gzip 512 B 512 B
Overall change 512 B 512 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/trace-resolving Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 531 B 531 B
Overall change 1.62 kB 1.62 kB
Commit: 08b7a00

@ijjk ijjk merged commit 38ac55d into vercel:canary Sep 29, 2021
@ijjk ijjk deleted the update/trace-resolving branch September 29, 2021 17:38
kodiakhq bot pushed a commit that referenced this pull request Sep 30, 2021
Follow-up to #29473 after additional testing it seems we need to ensure the `main` field is used when tracing packages during builds so that `module` isn't being used unexpectedly.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants