New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace server chunk handling in outputPath with chunkFilename #29560
Conversation
Failing test suitesCommit: b417ded test/e2e/prerender.test.ts
Expand output● Prerender › should output traces
test/integration/gssp-ssr-change-reloading/test/index.test.js
Expand output● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSSP
● GS(S)P Server-Side Change Reloading › should update page when getServerSideProps is changed only
✓ stest/integration/production/test/index.test.js
Expand output● Production Usage › should output traces
|
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.33 | 3.259 | -0.07 |
/ avg req/sec | 750.74 | 767.08 | +16.34 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.552 | 1.586 | |
/error-in-render avg req/sec | 1610.72 | 1576.1 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
779.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.9 kB | 26.9 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.8 kB | 70.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
_app-HASH.js gzip | 977 B | 977 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 311 B | 311 B | ✓ |
css-HASH.js gzip | 328 B | 328 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.15 kB | 4.15 kB | ✓ |
index-HASH.js gzip | 260 B | 260 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
script-HASH.js gzip | 386 B | 386 B | ✓ |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
_buildManifest.js gzip | 494 B | 494 B | ✓ |
Overall change | 494 B | 494 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
buildDuration | 7.8s | 7.7s | -84ms |
buildDurationCached | 3.9s | 3.7s | -145ms |
nodeModulesSize | 183 MB | 183 MB | -739 B |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.165 | 3.261 | |
/ avg req/sec | 789.96 | 766.61 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.471 | 1.552 | |
/error-in-render avg req/sec | 1699.07 | 1610.57 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
770.HASH.js gzip | 178 B | 178 B | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.9 kB | 34.9 kB | ✓ |
webpack-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 315 B | 315 B | ✓ |
css-HASH.js gzip | 331 B | 331 B | ✓ |
dynamic-HASH.js gzip | 2.79 kB | 2.79 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 637 B | 637 B | ✓ |
image-HASH.js gzip | 573 B | 573 B | ✓ |
index-HASH.js gzip | 262 B | 262 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 326 B | 326 B | ✓ |
script-HASH.js gzip | 393 B | 393 B | ✓ |
withRouter-HASH.js gzip | 322 B | 322 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
_buildManifest.js gzip | 511 B | 511 B | ✓ |
Overall change | 511 B | 511 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | sam3d/next.js wasm-chunks-fix | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
The ../ is a workaround for node-file-trace to only include files in the chunks directory. |
df8579c
to
47e5ebe
Compare
e078ebe
to
6b863fe
Compare
Fixes #29485 #29362
The problem
Using
chunks
in theoutput.path
directory and then using../
to recurse up a directory for ordinary files breakswebassemblyModuleFilename
, as it outputs into thechunks
directory but then looks for the webpack module at the root ofserver
. This renders it unable to find the file.The fix
Use the
chunkFilename
to handle thechunks
subdirectory instead, and replace the relative path handlers introduced with what they had before