-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upate swc to allow line comments in css #29943
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a26d473
Print css on parisng failure
kdy1 9b3294f
Update swc
kdy1 a37ab66
Update swc
kdy1 a2fb7a3
PAtch
kdy1 f4a4889
Add a test
kdy1 f6c5b67
Update test refs
kdy1 91f1d54
Build next-swc binaries
kdy1 60a01a4
Merge branch 'canary' into swc
kodiakhq[bot] 1e3d96a
Enable // flag
timneutkens File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/next/build/swc/tests/fixture/styled-jsx/comments/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
export default class { | ||
render() { | ||
return ( | ||
<div> | ||
<p>test</p> | ||
<style jsx>{` | ||
// | ||
p { | ||
// | ||
color: red; | ||
|
||
// | ||
} | ||
`}</style> | ||
</div> | ||
) | ||
} | ||
} |
12 changes: 12 additions & 0 deletions
12
packages/next/build/swc/tests/fixture/styled-jsx/comments/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import _JSXStyle from "styled-jsx/style"; | ||
export default class { | ||
render() { | ||
return <div className={"jsx-1952086b0a5ae64c"}> | ||
|
||
<p className={"jsx-1952086b0a5ae64c"}>test</p> | ||
|
||
<_JSXStyle id={"1952086b0a5ae64c"}>{"p.jsx-1952086b0a5ae64c {color:red}"}</_JSXStyle> | ||
|
||
</div>; | ||
} | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not really "wrong", just not standardized in the spec. It works it some browsers.
I would call this
allow_nonstandard_line_comments
orallow_unofficial_line_comments
🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm,
nonstandard
seems better.Thasnk!