Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom server docs for async methods #30521

Merged
merged 4 commits into from
Feb 6, 2022
Merged

Update custom server docs for async methods #30521

merged 4 commits into from
Feb 6, 2022

Commits on Oct 28, 2021

  1. handle() is a Promise 

    as handle() returned from app.getRequestHandler() is a Promise, it has to be handled correctly. Simply returning it, works fine.
    @fmacherey
    fmacherey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    6f0ef09 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into patch-1

    @fmacherey
    fmacherey committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    fa264cc View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. Merge branch 'canary' into patch-1

    @ijjk
    ijjk committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    8695b4c View commit details
    Browse the repository at this point in the history

  2. ensure async methods are awaited

    @ijjk
    ijjk committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    4b142dd View commit details
    Browse the repository at this point in the history