Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of next-swc on musl #30740

Closed
wants to merge 7 commits into from
Closed

Fix loading of next-swc on musl #30740

wants to merge 7 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 1, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes #30713

timneutkens
timneutkens previously approved these changes Nov 1, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 1, 2021

Failing test suites

Commit: 5593a03

test/production/typescript-basic.test.ts

  • TypeScript basic > have built and started correctly
Expand output

● TypeScript basic › have built and started correctly

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   6 |   let next: NextInstance
   7 |
>  8 |   beforeAll(async () => {
     |   ^
   9 |     next = await createNext({
  10 |       files: {
  11 |         'pages/index.tsx': `

  at production/typescript-basic.test.ts:8:3
  at Object.<anonymous> (production/typescript-basic.test.ts:5:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  30 |         '@types/react': '16.9.17',
  31 |       },
> 32 |     })
     |       ^
  33 |   })
  34 |   afterAll(() => next.destroy())
  35 |

  at production/typescript-basic.test.ts:32:23

● Test suite failed to run

next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished

  77 |     if (nextInstance) {
  78 |       await nextInstance.destroy()
> 79 |       throw new Error(
     |             ^
  80 |         `next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished`
  81 |       )
  82 |     }

  at lib/e2e-utils.ts:79:13

@ijjk
Copy link
Member

ijjk commented Nov 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js musl-binding Change
buildDuration 21.9s 20.9s -1s
buildDurationCached 4.5s 4.4s -156ms
nodeModulesSize 293 MB 293 MB ⚠️ +134 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js musl-binding Change
/ failed reqs 0 0
/ total time (seconds) 3.481 3.419 -0.06
/ avg req/sec 718.13 731.2 +13.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.6 1.557 -0.04
/error-in-render avg req/sec 1562.52 1605.84 +43.32
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js musl-binding Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js musl-binding Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js musl-binding Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js musl-binding Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js musl-binding Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js musl-binding Change
buildDuration 22s 22s ⚠️ +13ms
buildDurationCached 4.4s 4.4s -32ms
nodeModulesSize 293 MB 293 MB ⚠️ +134 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js musl-binding Change
/ failed reqs 0 0
/ total time (seconds) 3.281 3.173 -0.11
/ avg req/sec 761.89 788.01 +26.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.528 1.432 -0.1
/error-in-render avg req/sec 1636.21 1745.23 +109.02
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js musl-binding Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js musl-binding Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js musl-binding Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js musl-binding Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js musl-binding Change
index.html gzip 535 B 535 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 5593a03

@@ -34,6 +34,7 @@ for (const triple of triples) {
loadError = e
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually this break that needs to be removed. I was thinking that if the file existed and it failed to load, it must be a problem with the file, but it seems like if a file fails to load that's a signal to check if there is another file that works.

@padmaia
Copy link
Member

padmaia commented Nov 1, 2021

Opened up a new PR since it is off hours for @kdy1. Going to close this one.

@padmaia padmaia closed this Nov 1, 2021
@kdy1 kdy1 deleted the musl-binding branch January 20, 2022 07:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading shared library ld-linux-x86-64.so.2 on Alpine
5 participants