Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require source files to be writeable in dev mode #30758

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Don't require source files to be writeable in dev mode #30758

merged 2 commits into from
Nov 2, 2021

Commits on Nov 2, 2021

  1. Don't require source files to be writeable in dev mode 

    Currently, hot reloading is broken when running dev mode in systems
like Bazel, where the source files are marked as read-only. The dev
server will not render pages, and the browser's request will hang
when trying to load a page.

This is caused by a check in the hot reloader to see if a file exists,
which is currently done by seeing if the file is writeable. The goal
of the check is merely to see if a file exists, so checking for read
permissions should be sufficient.
    Evan Bradley committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    9f0beec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into fix-hot-reloader-permissions-check

    @ijjk
    ijjk committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    1e8459f View commit details
    Browse the repository at this point in the history