Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reason message for isolatedModules and esModuleInterop #31150

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

timneutkens
Copy link
Member

This is still required with SWC. The message just wasn't updated.

Fixes #31149

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This is still required with SWC. The message just wasn't updated.

Fixes vercel#31149
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 8, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
buildDuration 23.8s 24s ⚠️ +217ms
buildDurationCached 4.7s 4.6s -85ms
nodeModulesSize 332 MB 332 MB ⚠️ +20 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
/ failed reqs 0 0
/ total time (seconds) 4.117 4.058 -0.06
/ avg req/sec 607.17 616.09 +8.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.053 2.033 -0.02
/error-in-render avg req/sec 1217.92 1229.43 +11.51
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
buildDuration 25.9s 26.1s ⚠️ +149ms
buildDurationCached 4.7s 4.7s ⚠️ +6ms
nodeModulesSize 332 MB 332 MB ⚠️ +20 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
/ failed reqs 0 0
/ total time (seconds) 3.987 4.051 ⚠️ +0.06
/ avg req/sec 627 617.17 ⚠️ -9.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.145 2.086 -0.06
/error-in-render avg req/sec 1165.29 1198.54 +33.25
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/isolatedmodules-message Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.57 kB 1.57 kB
Commit: 6639d3b

@kodiakhq kodiakhq bot merged commit 9d7900c into vercel:canary Nov 8, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Requirement: isolatedModules is set to true for babel when not using babel
2 participants