Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor server/render for SSR streaming #31231
Refactor server/render for SSR streaming #31231
Changes from 4 commits
1916e52
200159e
6d2a6d2
b932c72
ae4fa67
9df1420
68443bb
a98da84
db060e1
d6d3884
cd946bd
51a8c15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this to compile time, but that doesn't block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An overall refactoring to the middleware,
server/next-server
andserver/render
is needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, Frameworks shouldn't insert suspense boundaries, because the app has no way to customize the fallback/loading state. What do we need this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it's implemented in Next.js today:
next.js/packages/next/build/webpack/loaders/next-middleware-ssr-loader/index.ts
Lines 92 to 98 in 28a5d7a
and previously the top-level suspense boundary didn't exist. We can surely get rid of it, but I'm unsure if it will cause hydration mismatch on the client side since we'll need a boundary there.