Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jsxImportSource in tsconfig/jsconfig #31358

Merged
merged 1 commit into from
Nov 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/next/build/swc/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ function getBaseSWCOptions({
styledComponents,
paths,
baseUrl,
importSource,
}) {
const isTSFile = filename.endsWith('.ts')
const isTypeScript = isTSFile || filename.endsWith('.tsx')
Expand All @@ -30,6 +31,7 @@ function getBaseSWCOptions({

transform: {
react: {
importSource: importSource || 'react',
runtime: 'automatic',
pragma: 'React.createElement',
pragmaFrag: 'React.Fragment',
Expand Down Expand Up @@ -103,13 +105,15 @@ export function getLoaderSWCOptions({
isPageFile,
hasReactRefresh,
styledComponents,
importSource,
}) {
let baseOptions = getBaseSWCOptions({
filename,
development,
globalWindow: !isServer,
hasReactRefresh,
styledComponents,
importSource,
})

const isNextDist = nextDistPath.test(filename)
Expand Down
10 changes: 5 additions & 5 deletions packages/next/build/webpack-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,10 @@ export default async function getBaseWebpackConfig(
runWebpackSpan: Span
}
): Promise<webpack.Configuration> {
const { useTypeScript, jsConfig, resolvedBaseUrl } = await loadJsConfig(
dir,
config
)
const supportedBrowsers = await getSupportedBrowsers(dir, dev)
const hasRewrites =
rewrites.beforeFiles.length > 0 ||
Expand Down Expand Up @@ -438,6 +442,7 @@ export default async function getBaseWebpackConfig(
pagesDir,
hasReactRefresh: !isMiddleware && hasReactRefresh,
styledComponents: config.experimental.styledComponents,
importSource: jsConfig?.compilerOptions?.jsxImportSource,
},
}
: {
Expand Down Expand Up @@ -521,11 +526,6 @@ export default async function getBaseWebpackConfig(
} as ClientEntries)
: undefined

const { useTypeScript, jsConfig, resolvedBaseUrl } = await loadJsConfig(
dir,
config
)

function getReactProfilingInProduction() {
if (reactProductionProfiling) {
return {
Expand Down
10 changes: 8 additions & 2 deletions packages/next/build/webpack/loaders/next-swc-loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ async function loaderTransform(parentTrace, source, inputSourceMap) {

let loaderOptions = this.getOptions() || {}

const { isServer, pagesDir, hasReactRefresh, styledComponents } =
loaderOptions
const {
isServer,
pagesDir,
hasReactRefresh,
styledComponents,
importSource,
} = loaderOptions
const isPageFile = filename.startsWith(pagesDir)

const swcOptions = getLoaderSWCOptions({
Expand All @@ -47,6 +52,7 @@ async function loaderTransform(parentTrace, source, inputSourceMap) {
development: this.mode === 'development',
hasReactRefresh,
styledComponents,
importSource,
})

const programmaticOptions = {
Expand Down
35 changes: 35 additions & 0 deletions test/development/basic/theme-ui.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { join } from 'path'
import webdriver from 'next-webdriver'
import { createNext, FileRef } from 'e2e-utils'
import { NextInstance } from 'test/lib/next-modes/base'

describe('theme-ui SWC option', () => {
let next: NextInstance

beforeAll(async () => {
next = await createNext({
files: {
'jsconfig.json': new FileRef(join(__dirname, 'theme-ui/jsconfig.json')),
pages: new FileRef(join(__dirname, 'theme-ui/pages')),
'theme.js': new FileRef(join(__dirname, 'theme-ui/theme.js')),
},
dependencies: {
'theme-ui': '0.12.0',
},
})
})
afterAll(() => next.destroy())

it('should have theme provided styling', async () => {
let browser
try {
browser = await webdriver(next.appPort, '/')
const color = await browser.elementByCss('#hello').getComputedCss('color')
expect(color).toBe('rgb(51, 51, 238)')
} finally {
if (browser) {
await browser.close()
}
}
})
})
5 changes: 5 additions & 0 deletions test/development/basic/theme-ui/jsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"compilerOptions": {
"jsxImportSource": "theme-ui"
}
}
13 changes: 13 additions & 0 deletions test/development/basic/theme-ui/pages/_app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// basic usage
import { ThemeProvider } from 'theme-ui'
import theme from '../theme'

function MyApp({ Component, pageProps }) {
return (
<ThemeProvider theme={theme}>
<Component {...pageProps} />
</ThemeProvider>
)
}

export default MyApp
14 changes: 14 additions & 0 deletions test/development/basic/theme-ui/pages/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
export default function Home() {
return (
<div
id="hello"
sx={{
fontWeight: 'bold',
fontSize: 4, // picks up value from `theme.fontSizes[4]`
color: 'primary', // picks up value from `theme.colors.primary`
}}
>
Hello
</div>
)
}
13 changes: 13 additions & 0 deletions test/development/basic/theme-ui/theme.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// example theme.js
export default {
fonts: {
body: 'system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", sans-serif',
heading: '"Avenir Next", sans-serif',
monospace: 'Menlo, monospace',
},
colors: {
text: '#000',
background: '#fff',
primary: '#33e',
},
}