Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript Documentation Improvement for Persistent Layouts #33659

Merged
merged 4 commits into from Aug 22, 2022
Merged

Typescript Documentation Improvement for Persistent Layouts #33659

merged 4 commits into from Aug 22, 2022
+1 −1

Commits on Jan 25, 2022

  1. Update layouts.md 

    By allowing `NextPageWithLayout` to accept an optional generic type, we can continue to specify our props explicitly on pages that use this type. This gives us type safety in `getInitialProps`, for example.
    @davewelsh
    davewelsh committed Jan 25, 2022
    Copy the full SHA
    e3d09f5 View commit details
    Browse the repository at this point in the history

  2. Use the same generics as NextPage

    @davewelsh
    davewelsh committed Jan 25, 2022
    Copy the full SHA
    16d8255 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge branch 'canary' into patch-1

    @leerob
    leerob committed Aug 22, 2022
    Copy the full SHA
    3b90c9f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into patch-1

    @kodiakhq
    kodiakhq[bot] committed Aug 22, 2022
    Copy the full SHA
    c895e86 View commit details
    Browse the repository at this point in the history