Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renderToPipeableStream when available #33886

Closed
wants to merge 7 commits into from

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Feb 1, 2022

WIP

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Feb 1, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 2, 2022

Failing test suites

Commit: 37e7c65

test/integration/ondemand/test/index.test.js

  • On Demand Entries > should navigate to pages with dynamic imports
Expand output

● On Demand Entries › should navigate to pages with dynamic imports

TIMED OUT: /Hello/

/nav/dynamic

  479 | }
  480 |
> 481 | export class File {
      |               ^
  482 |   constructor(path) {
  483 |     this.path = path
  484 |     this.originalContent = existsSync(this.path)

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (integration/ondemand/test/index.test.js:102:13)

@ijjk
Copy link
Member

ijjk commented Feb 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
buildDuration 13.9s 14s ⚠️ +107ms
buildDurationCached 3.2s 3.2s -31ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.61 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
/ failed reqs 0 0
/ total time (seconds) 3.044 2.981 -0.06
/ avg req/sec 821.39 838.7 +17.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.429 1.396 -0.03
/error-in-render avg req/sec 1749.28 1790.92 +41.64
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
buildDuration 16.2s 16.5s ⚠️ +353ms
buildDurationCached 3.2s 3.3s ⚠️ +24ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.61 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
/ failed reqs 0 0
/ total time (seconds) 2.944 2.983 ⚠️ +0.04
/ avg req/sec 849.15 838.21 ⚠️ -10.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.447 1.39 -0.06
/error-in-render avg req/sec 1728 1798.49 +70.49
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-new-ssr-when-available Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 37e7c65

@devknoll
Copy link
Contributor Author

devknoll commented Feb 8, 2022

Replaced with #34106

@devknoll devknoll closed this Feb 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants