Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/active-class-name #34205

Merged
merged 4 commits into from Feb 11, 2022
Merged

Update examples/active-class-name #34205

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ec40da
Change asPath to pathname
Feb 10, 2022
5f669ec
Merge branch 'canary' into update-active-class-name
xhoantran Feb 10, 2022
9f8d333
Add rewrites in next.config.js and update ActiveLink
Feb 11, 2022
5e024b0
Merge branch 'canary' into update-active-class-name
xhoantran Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/active-class-name/components/ActiveLink.js
View file
Open in desktop
Expand Up @@ -4,15 +4,15 @@ import Link from 'next/link'
import React, { Children } from 'react'

const ActiveLink = ({ children, activeClassName, ...props }) => {
const { asPath } = useRouter()
const { pathname } = useRouter()
const child = Children.only(children)
const childClassName = child.props.className || ''

// pages/index.js will be matched via props.href
// pages/about.js will be matched via props.href
// pages/[slug].js will be matched via props.as
const className =
asPath === props.href || asPath === props.as
pathname === props.href || pathname === props.as
? `${childClassName} ${activeClassName}`.trim()
: childClassName

xhoantran marked this conversation as resolved.
Show resolved Hide resolved
Expand Down