Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello world example for RSC. #34301

Closed
wants to merge 5 commits into from
Closed

Add hello world example for RSC. #34301

wants to merge 5 commits into from

Conversation

leerob
Copy link
Member

@leerob leerob commented Feb 13, 2022

To assist with the docs: #33986

@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team labels Feb 13, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@leerob
Copy link
Member Author

leerob commented Feb 16, 2022

This is good to merge now!

@ijjk
Copy link
Member

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js rsc-hello-world Change
buildDuration 21.3s 21.3s -71ms
buildDurationCached 8.1s 8.1s ⚠️ +42ms
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js rsc-hello-world Change
/ failed reqs 0 0
/ total time (seconds) 4.639 4.696 ⚠️ +0.06
/ avg req/sec 538.86 532.34 ⚠️ -6.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.253 2.358 ⚠️ +0.1
/error-in-render avg req/sec 1109.8 1060.01 ⚠️ -49.79
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rsc-hello-world Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rsc-hello-world Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js rsc-hello-world Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rsc-hello-world Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rsc-hello-world Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js rsc-hello-world Change
buildDuration 25.5s 25.6s ⚠️ +117ms
buildDurationCached 8.2s 8.1s -92ms
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js rsc-hello-world Change
/ failed reqs 0 0
/ total time (seconds) 4.662 4.74 ⚠️ +0.08
/ avg req/sec 536.29 527.4 ⚠️ -8.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.375 2.265 -0.11
/error-in-render avg req/sec 1052.64 1103.77 +51.13
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rsc-hello-world Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rsc-hello-world Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js rsc-hello-world Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rsc-hello-world Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rsc-hello-world Change
index.html gzip 533 B 533 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: c87473c

@leerob leerob closed this Feb 17, 2022
@leerob leerob deleted the rsc-hello-world branch February 17, 2022 02:01
kodiakhq bot pushed a commit that referenced this pull request Feb 17, 2022
Let's wait until we have a better place for folks to start that doesn't include my hacky code 😄 For now, we can continue to point to the demos we have previously created, which have the proper guidance and caveats. 

Replaces #34301.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants