Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing tests for GS(S)P server only changes #34396

Closed
wants to merge 2 commits into from
Closed

Add failing tests for GS(S)P server only changes #34396

wants to merge 2 commits into from

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 16, 2022

Adds failing tests for fix in #34298

x-ref: #34298

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Feb 16, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 16, 2022

Failing test suites

Commit: c4e6ffc

yarn testheadless test/development/basic/gssp-ssr-change-reloading/test/index.test.ts

  • GS(S)P Server-Side Change Reloading > should update page when getStaticProps is changed only
  • GS(S)P Server-Side Change Reloading > should show indicator when re-fetching data
  • GS(S)P Server-Side Change Reloading > should update page when getStaticPaths is changed only
  • GS(S)P Server-Side Change Reloading > should update page when getServerSideProps is changed only
  • GS(S)P Server-Side Change Reloading > should update on props error in getStaticProps
  • GS(S)P Server-Side Change Reloading > should update on thrown error in getStaticProps
Expand output

● GS(S)P Server-Side Change Reloading › should update page when getStaticProps is changed only

TIMED OUT: 2

1

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:69:5)

● GS(S)P Server-Side Change Reloading › should show indicator when re-fetching data

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  88 |
  89 |     const props = JSON.parse(await browser.elementByCss('#props').text())
> 90 |     expect(props.count).toBe(1)
     |                         ^
  91 |
  92 |     const page = 'pages/gsp-blog/[post].js'
  93 |     const originalContent = await next.readFile(page)

  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:90:25)

● GS(S)P Server-Side Change Reloading › should update page when getStaticPaths is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  118 |
  119 |     const props = JSON.parse(await browser.elementByCss('#props').text())
> 120 |     expect(props.count).toBe(1)
      |                         ^
  121 |
  122 |     const page = 'pages/gsp-blog/[post].js'
  123 |     const originalContent = await next.readFile(page)

  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:120:25)

● GS(S)P Server-Side Change Reloading › should update page when getServerSideProps is changed only

TIMED OUT: 2

1

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:209:5)

● GS(S)P Server-Side Change Reloading › should update on props error in getStaticProps

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  234 |     try {
  235 |       await next.patchFile(page, originalContent.replace('props:', 'propss:'))
> 236 |       expect(await hasRedbox(browser, true)).toBe(true)
      |                                              ^
  237 |       expect(await getRedboxHeader(browser)).toContain(
  238 |         'Additional keys were returned from'
  239 |       )

  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:236:46)

● GS(S)P Server-Side Change Reloading › should update on thrown error in getStaticProps

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  264 |         )
  265 |       )
> 266 |       expect(await hasRedbox(browser, true)).toBe(true)
      |                                              ^
  267 |       expect(await getRedboxHeader(browser)).toContain('custom oops')
  268 |
  269 |       await next.patchFile(page, originalContent)

  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:266:46)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member Author

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/server-only-tests Change
buildDuration 23.9s 23.8s -49ms
buildDurationCached 9.1s 9.1s ⚠️ +52ms
nodeModulesSize 367 MB 367 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/server-only-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 5.107 5.193 ⚠️ +0.09
/ avg req/sec 489.55 481.39 ⚠️ -8.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.394 2.423 ⚠️ +0.03
/error-in-render avg req/sec 1044.49 1031.89 ⚠️ -12.6
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/server-only-tests Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/server-only-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/server-only-tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.01 kB 5.01 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/server-only-tests Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/server-only-tests Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/server-only-tests Change
buildDuration 29.1s 28.4s -710ms
buildDurationCached 8.8s 8.8s ⚠️ +57ms
nodeModulesSize 367 MB 367 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/server-only-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 5.049 5.139 ⚠️ +0.09
/ avg req/sec 495.17 486.47 ⚠️ -8.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.392 2.351 -0.04
/error-in-render avg req/sec 1045.16 1063.56 +18.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/server-only-tests Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/server-only-tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/server-only-tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/server-only-tests Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/server-only-tests Change
index.html gzip 533 B 533 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: c4e6ffc

@ijjk ijjk mentioned this pull request Feb 16, 2022
Merged
3 tasks
@ijjk ijjk closed this Feb 16, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 16, 2022

Merged into #34298

@ijjk ijjk deleted the add/server-only-tests branch February 16, 2022 01:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding will be requested when the pull request is marked ready for review shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi will be requested when the pull request is marked ready for review huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim will be requested when the pull request is marked ready for review feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner will be requested when the pull request is marked ready for review ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh will be requested when the pull request is marked ready for review wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk