New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose WASM bindings in Middleware #34437
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bebbb53
Expose wasm files in middleware-manifest
Schniz d629fd9
Update packages/next/build/webpack/loaders/next-middleware-wasm-loade…
Schniz 1d7f88e
wasmBindings => wasm
Schniz 2150dae
Add a test
Schniz e0aeabf
add the failing test
Schniz 3c48003
set the type to javascript/auto instead of wasm
Schniz 57c80de
force a resource query
Schniz 7a791c0
Don't use optional on crypto randomUuid
Schniz 07cae23
Update packages/next/build/webpack-config.ts
Schniz 7bdd4e2
Revert "Don't use optional on crypto randomUuid"
Schniz fb4bb21
Merge branch 'canary' into expose-wasm-files
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
packages/next/build/webpack/loaders/next-middleware-wasm-loader.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import crypto from 'crypto' | ||
|
||
export type WasmBinding = { | ||
filePath: string | ||
name: string | ||
} | ||
|
||
export default function MiddlewareWasmLoader(this: any, source: Buffer) { | ||
const name = `wasm_${sha1(source)}` | ||
const filePath = `server/middleware-chunks/${name}.wasm` | ||
const binding: WasmBinding = { filePath, name } | ||
this._module.buildInfo.nextWasmMiddlewareBinding = binding | ||
this.emitFile(`/${filePath}`, source, null) | ||
return `module.exports = ${name};` | ||
} | ||
|
||
export const raw = true | ||
|
||
function sha1(source: string | Buffer) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it better to use |
||
return crypto.createHash('sha1').update(source).digest('hex') | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to prefix this? Otherwise its going to change all wasm imports instead of just middleware, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the secret sauce is
issuerLayer
which should only affect the middleware layer