Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#34030): ignore non-checkable jsx spread attribute #34473

Merged
merged 6 commits into from
Feb 25, 2022

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Feb 17, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes #34030.

The PR is still WIP as the test case hasn't been added, help or change is welcome.

cc @no-ya @ijjk

@ijjk ijjk marked this pull request as ready for review February 25, 2022 01:56
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Feb 25, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary SukkaW/next.js fix-34030 Change
buildDuration 15.1s 15.2s ⚠️ +77ms
buildDurationCached 5.8s 6s ⚠️ +113ms
nodeModulesSize 367 MB 367 MB -15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SukkaW/next.js fix-34030 Change
/ failed reqs 0 0
/ total time (seconds) 2.797 2.897 ⚠️ +0.1
/ avg req/sec 893.97 862.86 ⚠️ -31.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.33 1.371 ⚠️ +0.04
/error-in-render avg req/sec 1880.36 1824.05 ⚠️ -56.31
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-34030 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-34030 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-34030 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-34030 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-34030 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary SukkaW/next.js fix-34030 Change
buildDuration 19.8s 19.5s -306ms
buildDurationCached 6.2s 6.2s ⚠️ +5ms
nodeModulesSize 367 MB 367 MB -15 B
Page Load Tests Overall increase ✓
vercel/next.js canary SukkaW/next.js fix-34030 Change
/ failed reqs 0 0
/ total time (seconds) 3.058 2.994 -0.06
/ avg req/sec 817.45 835.1 +17.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.422 1.374 -0.05
/error-in-render avg req/sec 1757.53 1820.14 +62.61
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fix-34030 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fix-34030 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fix-34030 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fix-34030 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fix-34030 Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 03ccef2

@kodiakhq kodiakhq bot merged commit 3ee458e into vercel:canary Feb 25, 2022
@no-yan
Copy link

no-yan commented Feb 26, 2022

Great! Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
@SukkaW SukkaW deleted the fix-34030 branch October 24, 2023 08:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next/inline-script-id does not handle JSXSpreadAttributes correctly
3 participants