Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react-dom type error in CNA typescript template #34623

Merged
merged 9 commits into from Feb 24, 2022
Merged

Fix react-dom type error in CNA typescript template #34623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06cd5de
Add @types/react-dom devDependencies
eungyeole Feb 21, 2022
fe28361
fix: eslint error
eungyeole Feb 21, 2022
8184633
fix: eslint error 2
eungyeole Feb 21, 2022
2fe6a55
Merge branch 'canary' into canary
eungyeole Feb 21, 2022
669e750
Merge branch 'canary' into canary
eungyeole Feb 22, 2022
3dc4b31
Merge branch 'canary' into canary
eungyeole Feb 22, 2022
53e3fe4
Merge branch 'vercel:canary' into canary
eungyeole Feb 22, 2022
9774304
Merge branch 'canary' into canary
eungyeole Feb 23, 2022
1ee48e2
Merge branch 'canary' into canary
eungyeole Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/create-next-app/create-app.ts
View file
Open in desktop
Expand Up @@ -234,7 +234,12 @@ export async function createApp({
* TypeScript projects will have type definitions and other devDependencies.
*/
if (typescript) {
devDependencies.push('typescript', '@types/react', '@types/node')
devDependencies.push(
'typescript',
'@types/react',
'@types/node',
'@types/react-dom'
)
}
/**
* Install package.json dependencies if they exist.
Expand Down
1 change: 1 addition & 0 deletions test/integration/create-next-app/index.test.js
View file
Open in desktop
Expand Up @@ -143,6 +143,7 @@ describe('create next app', () => {
expect(Object.keys(pkgJSON.devDependencies)).toEqual([
'@types/node',
'@types/react',
'@types/react-dom',
'eslint',
'eslint-config-next',
'typescript',
Expand Down