Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the functions manifest plugin #35155

Merged
merged 3 commits into from Mar 9, 2022
Merged

Disable the functions manifest plugin #35155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
751eb7d
Disable the functions manifest plugin
huozhi Mar 8, 2022
fe12915
remove outdated test
huozhi Mar 8, 2022
cf7f74f
Merge branch 'canary' into disable-functions-manifest-plugin
huozhi Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/next/build/webpack-config.ts
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@ import { regexLikeCss } from './webpack/config/blocks/css'
import { CopyFilePlugin } from './webpack/plugins/copy-file-plugin'
import { FlightManifestPlugin } from './webpack/plugins/flight-manifest-plugin'
import { TelemetryPlugin } from './webpack/plugins/telemetry-plugin'
import FunctionsManifestPlugin from './webpack/plugins/functions-manifest-plugin'
import type { Span } from '../trace'
import { getRawPageExtensions } from './utils'
import browserslist from 'next/dist/compiled/browserslist'
Expand Down Expand Up @@ -1446,14 +1445,6 @@ export default async function getBaseWebpackConfig(
// replacement is done before its process.env.* handling
(!isServer || isEdgeRuntime) &&
new MiddlewarePlugin({ dev, isEdgeRuntime }),
process.env.ENABLE_FILE_SYSTEM_API === '1' &&
isEdgeRuntime &&
new FunctionsManifestPlugin({
dev,
pagesDir,
isEdgeRuntime,
pageExtensions: config.pageExtensions,
}),
!isServer &&
new BuildManifestPlugin({
buildId,
Expand Down
2 changes: 2 additions & 0 deletions packages/next/build/webpack/plugins/functions-manifest-plugin.ts
View file
Open in desktop
@@ -1,3 +1,5 @@
// TODO: rewrite against the stable edge functions standard

import { relative } from 'path'
import { sources, webpack5 } from 'next/dist/compiled/webpack/webpack'
import { normalizePagePath } from '../../../server/normalize-page-path'
Expand Down
3 changes: 0 additions & 3 deletions test/integration/react-streaming-and-server-components/test/index.test.js
View file
Open in desktop
Expand Up @@ -24,7 +24,6 @@ import css from './css'
import rsc from './rsc'
import streaming from './streaming'
import basic from './basic'
import functions from './functions'
import runtime from './runtime'

const documentWithGip = `
Expand Down Expand Up @@ -279,8 +278,6 @@ runSuite('CSS', 'prod', cssSuite)
runSuite('Custom Document', 'dev', documentSuite)
runSuite('Custom Document', 'prod', documentSuite)

runSuite('Functions manifest', 'build', { runTests: functions })

function runSuite(suiteName, env, options) {
const context = { appDir, distDir }
describe(`${suiteName} ${env}`, () => {
Expand Down