Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Adds try/catch to gracefully handle performance observer exception #35202

Merged
merged 3 commits into from Mar 10, 2022
Merged

[Fix] Adds try/catch to gracefully handle performance observer exception #35202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7249b73
fix: add try/catch to gracefull handle performance observer exception…
huzaifarif Mar 10, 2022
14638c8
fix: run prettier
huzaifarif Mar 10, 2022
dc60a16
Merge branch 'canary' into fix/35200-performance-observer-error
styfle Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/next/client/image.tsx
View file
Open in desktop
Expand Up @@ -516,7 +516,15 @@ export default function Image({
}
}
})
perfObserver.observe({ type: 'largest-contentful-paint', buffered: true })
try {
perfObserver.observe({
type: 'largest-contentful-paint',
buffered: true,
})
} catch (err) {
// Log error but don't crash the app
console.error(err)
}
}
}

Expand Down