Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments for the web server #35366

Merged
merged 2 commits into from Mar 16, 2022
Merged

Update comments for the web server #35366

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2f357d
update comments
shuding Mar 16, 2022
da9e0f5
Merge branch 'canary' into shu/53d8
kodiakhq[bot] Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/next/server/web-server.ts
View file
Open in desktop
Expand Up @@ -31,7 +31,8 @@ export default class NextWebServer extends BaseServer {
}
}
protected handleCompression() {
// @TODO
// For the web server layer, compression is automatically handled by the
// upstream proxy (edge runtime or node server) and we can simply skip here.
}
protected getRoutesManifest() {
return {
Expand All @@ -49,14 +50,15 @@ export default class NextWebServer extends BaseServer {
return ''
}
protected getPublicDir() {
// @TODO
// Public files are not handled by the web server.
return ''
}
protected getBuildId() {
return (globalThis as any).__server_context.buildId
}
protected loadEnvConfig() {
// @TODO
// The web server does not need to load the env config. This is done by the
// runtime already.
}
protected getHasStaticDir() {
return false
Expand Down