Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change the timing for clearing the inlined data buffer #35419

Closed
wants to merge 2 commits into from
Closed

Fix: change the timing for clearing the inlined data buffer #35419

wants to merge 2 commits into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 17, 2022 •
edited

Fix error of Unexpected server data: missing bootstrap script when the initial rendering is streaming rsc.

Introduced in #35344, the buffer might still keep flushing after on mount.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 17, 2022
@ijjk
Copy link
Member

ijjk commented Mar 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
buildDuration 15.7s 15.9s ⚠️ +156ms
buildDurationCached 6.1s 6.1s ⚠️ +23ms
nodeModulesSize 456 MB 456 MB ⚠️ +301 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.148 3.185 ⚠️ +0.04
/ avg req/sec 794.23 784.93 ⚠️ -9.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.376 1.391 ⚠️ +0.02
/error-in-render avg req/sec 1816.5 1797.58 ⚠️ -18.92
Client Bundles (main, webpack) Overall decrease ✓
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28 kB 28 kB -4 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB -4 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.48 kB 5.48 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.2 kB 15.2 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
index.html gzip 531 B 532 B ⚠️ +1 B
link.html gzip 545 B 546 B ⚠️ +1 B
withRouter.html gzip 525 B 526 B ⚠️ +1 B
Overall change 1.6 kB 1.6 kB ⚠️ +3 B

Diffs

Diff for main-HASH.js 
@@ -454,7 +454,7 @@
       exports.hydrate = hydrate;
       exports.emitter = exports.router = exports.version = void 0;
       __webpack_require__(37);
-      var _react = _interopRequireWildcard1(__webpack_require__(7294));
+      var _react = _interopRequireDefault1(__webpack_require__(7294));
       var _reactDom = _interopRequireDefault1(__webpack_require__(3935));
       var _headManagerContext = __webpack_require__(4664);
       var _mitt = _interopRequireDefault1(__webpack_require__(8550));
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
buildDuration 19.4s 19.2s -225ms
buildDurationCached 6.2s 6.1s -117ms
nodeModulesSize 456 MB 456 MB ⚠️ +301 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.152 3.178 ⚠️ +0.03
/ avg req/sec 793.02 786.73 ⚠️ -6.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.381 1.391 ⚠️ +0.01
/error-in-render avg req/sec 1810.26 1797.15 ⚠️ -13.11
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ⚠️ +2 B
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.1 kB 72.2 kB ⚠️ +2 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.59 kB 5.59 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.3 kB 15.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary huozhi/next.js rsc/check-initial-buffer Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 526 B -1 B
Overall change 1.6 kB 1.6 kB -1 B

Diffs

Diff for main-HASH.js 
@@ -454,7 +454,7 @@
       exports.hydrate = hydrate;
       exports.emitter = exports.router = exports.version = void 0;
       __webpack_require__(37);
-      var _react = _interopRequireWildcard1(__webpack_require__(7294));
+      var _react = _interopRequireDefault1(__webpack_require__(7294));
       var _reactDom = _interopRequireDefault1(__webpack_require__(3935));
       var _headManagerContext = __webpack_require__(4664);
       var _mitt = _interopRequireDefault1(__webpack_require__(8550));
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-fb3e61118240274c.js"
+      src="/_next/static/chunks/main-ab92f7a793525271.js"
       defer=""
     ></script>
     <script
Commit: fca138a

@huozhi huozhi closed this Apr 26, 2022
@huozhi huozhi deleted the rsc/check-initial-buffer branch April 26, 2022 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding will be requested when the pull request is marked ready for review shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim will be requested when the pull request is marked ready for review feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner will be requested when the pull request is marked ready for review ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh will be requested when the pull request is marked ready for review wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk