Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emotion SWC Plugin - Prevent spaces between expressions from being removed #35610

Closed
wants to merge 1 commit into from
Closed

Emotion SWC Plugin - Prevent spaces between expressions from being removed #35610

wants to merge 1 commit into from

Conversation

JohnDaly
Copy link
Contributor

fixes #35609

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@Brooooooklyn
Copy link
Contributor

Brooooooklyn commented Mar 26, 2022 •
edited by huozhi

@JohnDaly thanks for your contribution! Your commit is cherry-picked on #35613

@JohnDaly JohnDaly deleted the fix/emotion-swc-minify-expressions branch March 27, 2022 16:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emotion SWC Plugin - Spaces between expressions are being stripped
3 participants
@JohnDaly @Brooooooklyn @ijjk