Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global runtime for rsc by default #35759

Closed
wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 30, 2022

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 30, 2022
@ijjk
Copy link
Member

ijjk commented Mar 30, 2022

Failing test suites

Commit: c6b34d8

yarn testheadless test/integration/react-streaming-and-server-components/test/switchable-runtime.test.js

  • Without global runtime configuration > should build /node-rsc-ssg as a dynamic page with the nodejs runtime
Expand output

● Without global runtime configuration › should build /node-rsc-ssg as a dynamic page with the nodejs runtime

expect(received).toBeLessThan(expected)

Expected: < 1648680505257
Received:   1648680505257

  28 |   } else {
  29 |     // Should be re-rendered.
> 30 |     expect(renderedAt1).toBeLessThan(renderedAt2)
     |                         ^
  31 |   }
  32 | }
  33 |

  at testRoute (integration/react-streaming-and-server-components/test/switchable-runtime.test.js:30:25)
  at Object.<anonymous> (integration/react-streaming-and-server-components/test/switchable-runtime.test.js:91:5)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
buildDuration 19.5s 19.3s -187ms
buildDurationCached 7.3s 7.8s ⚠️ +426ms
nodeModulesSize 477 MB 477 MB ⚠️ +1.45 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
/ failed reqs 0 0
/ total time (seconds) 3.889 3.796 -0.09
/ avg req/sec 642.77 658.67 +15.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.726 1.663 -0.06
/error-in-render avg req/sec 1448.8 1503.42 +54.62
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
buildDuration 21.9s 22.5s ⚠️ +601ms
buildDurationCached 7.7s 7.8s ⚠️ +90ms
nodeModulesSize 477 MB 477 MB ⚠️ +1.45 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
/ failed reqs 0 0
/ total time (seconds) 3.95 3.85 -0.1
/ avg req/sec 632.94 649.29 +16.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.791 1.761 -0.03
/error-in-render avg req/sec 1395.67 1419.98 +24.31
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js no-static-opt-for-rsc Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: c6b34d8

@huozhi huozhi closed this Mar 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants