Adds eslint-plugin-eslint-plugin to ensure eslint-plugin-next rules follow ESLint rule best practices along with enforcing some consistency.

.eslintrc.json

@@ -145,6 +145,30 @@
           }
         ]
       }
+    },
+    {
+      "files": [
+        "packages/eslint-plugin-next/**/*.js",
+        "test/unit/eslint-plugin-next/**/*.test.ts"
+      ],
+      "extends": ["plugin:eslint-plugin/recommended"],
+      "parserOptions": {
+        "sourceType": "script"
+      },
+      "rules": {
+        "eslint-plugin/prefer-replace-text": "error",
+        "eslint-plugin/report-message-format": [
+          "error",
+          ".+\\. See: https://nextjs.org/docs/messages/[a-z\\-]+$"
+        ],
+        "eslint-plugin/require-meta-docs-description": [
+          "error",
+          {
+            "pattern": ".+"
+          }
+        ],
+        "eslint-plugin/require-meta-docs-url": "error"
+      }
     }
   ],
   "rules": {

package.json

@@ -123,6 +123,7 @@
     "escape-string-regexp": "2.0.0",
     "eslint": "7.24.0",
     "eslint-config-next": "workspace:*",
+    "eslint-plugin-eslint-plugin": "4.3.0",
     "eslint-plugin-import": "2.22.1",
     "eslint-plugin-jest": "24.3.5",
     "eslint-plugin-react": "7.23.2",

packages/eslint-plugin-next/lib/rules/google-font-display.js

@@ -9,6 +9,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {

packages/eslint-plugin-next/lib/rules/google-font-preconnect.js

@@ -9,6 +9,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {

packages/eslint-plugin-next/lib/rules/inline-script-id.js

@@ -8,6 +8,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     let nextScriptImportName = null

packages/eslint-plugin-next/lib/rules/next-script-for-ga.js

@@ -25,8 +25,9 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
-  schema: [],
   create: function (context) {
     return {
       JSXOpeningElement(node) {

packages/eslint-plugin-next/lib/rules/no-assign-module-variable.js

@@ -5,6 +5,8 @@ module.exports = {
       recommended: true,
       url: 'https://nextjs.org/docs/messages/no-assign-module-variable',
     },
+    type: 'problem',
+    schema: [],
   },
 
   create: function (context) {

packages/eslint-plugin-next/lib/rules/no-before-interactive-script-outside-document.js

@@ -11,6 +11,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     let scriptImportName = null

packages/eslint-plugin-next/lib/rules/no-css-tags.js

@@ -7,8 +7,9 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
-  schema: [],
   create: function (context) {
     return {
       JSXOpeningElement(node) {

packages/eslint-plugin-next/lib/rules/no-document-import-in-page.js

@@ -10,6 +10,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {

packages/eslint-plugin-next/lib/rules/no-duplicate-head.js

@@ -8,6 +8,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     let documentImportName

packages/eslint-plugin-next/lib/rules/no-head-element.js

@@ -8,7 +8,8 @@ module.exports = {
       recommended: true,
       url,
     },
-    fixable: 'code',
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {

packages/eslint-plugin-next/lib/rules/no-head-import-in-document.js

@@ -9,6 +9,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {

packages/eslint-plugin-next/lib/rules/no-html-link-for-pages.js

@@ -30,7 +30,7 @@ module.exports = {
       recommended: true,
       url,
     },
-    fixable: null, // or "code" or "whitespace"
+    type: 'problem',
     schema: [
       {
         oneOf: [

packages/eslint-plugin-next/lib/rules/no-img-element.js

@@ -8,7 +8,8 @@ module.exports = {
       recommended: true,
       url,
     },
-    fixable: 'code',
+    type: 'problem',
+    schema: [],
   },
 
   create: function (context) {

packages/eslint-plugin-next/lib/rules/no-page-custom-font.js

@@ -10,6 +10,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     const paths = context.getFilename().split('pages')

packages/eslint-plugin-next/lib/rules/no-script-component-in-head.js

@@ -8,6 +8,8 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     let isNextHead = null

packages/eslint-plugin-next/lib/rules/no-styled-jsx-in-document.js

@@ -9,7 +9,8 @@ module.exports = {
       recommended: true,
       url,
     },
-    fixable: 'code',
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     return {
@@ -44,5 +45,3 @@ module.exports = {
     }
   },
 }
-
-module.exports.schema = []

packages/eslint-plugin-next/lib/rules/no-sync-scripts.js

@@ -7,8 +7,9 @@ module.exports = {
       recommended: true,
       url,
     },
+    type: 'problem',
+    schema: [],
   },
-  schema: [],
   create: function (context) {
     return {
       JSXOpeningElement(node) {

packages/eslint-plugin-next/lib/rules/no-title-in-document-head.js

@@ -7,6 +7,8 @@ module.exports = {
         'Prevent usage of `<title>` with `Head` component from `next/document`.',
       url,
     },
+    type: 'problem',
+    schema: [],
   },
   create: function (context) {
     let headFromNextDocument = false

packages/eslint-plugin-next/lib/rules/no-typos.js

@@ -39,14 +39,15 @@ function minDistance(a, b) {
   return previousRow[previousRow.length - 1]
 }
 
+/* eslint-disable eslint-plugin/require-meta-docs-url */
 module.exports = {
   meta: {
     docs: {
       description: 'Prevent common typos in Next.js data fetching functions.',
-      category: 'Stylistic Issues',
       recommended: true,
     },
-    fixable: null,
+    type: 'problem',
+    schema: [],
   },
 
   create: function (context) {

packages/eslint-plugin-next/lib/rules/no-unwanted-polyfillio.js

@@ -72,7 +72,8 @@ module.exports = {
       recommended: true,
       url,
     },
-    fixable: null,
+    type: 'problem',
+    schema: [],
   },
 
   create: function (context) {