Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace placeholder.com images with *.vercel.app in image-component tests #38090

Merged
merged 7 commits into from Jun 30, 2022
Merged

Replace placeholder.com images with *.vercel.app in image-component tests #38090

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f957f6d
Replace all occurrences of placeholder.com with vercel.app in tests
maxproske Jun 28, 2022
281dbc8
Replace more occurances
maxproske Jun 28, 2022
e9f77b0
lint-fix
maxproske Jun 28, 2022
380da47
Merge branch 'canary' into feature/test-vercel-image-domain
ijjk Jun 29, 2022
f6fa175
Merge branch 'canary' into feature/test-vercel-image-domain
styfle Jun 30, 2022
588a717
Merge branch 'canary' into feature/test-vercel-image-domain
kodiakhq[bot] Jun 30, 2022
76bf489
Merge branch 'canary' into feature/test-vercel-image-domain
kodiakhq[bot] Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/image-component/typescript/next.config.js
View file
Open in desktop
@@ -1,6 +1,6 @@
module.exports = {
images: {
domains: ['via.placeholder.com'],
domains: ['image-optimization-test.vercel.app'],
// disableStaticImages: true,
},
}
6 changes: 3 additions & 3 deletions test/integration/image-component/typescript/pages/invalid.tsx
View file
Open in desktop
Expand Up @@ -8,20 +8,20 @@ const Invalid = () => {
<Image id="invalid-src" src={new Date()} width={500} height={500}></Image>
<Image
id="invalid-width"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={new Date()}
height={500}
></Image>
<Image
id="invalid-layout"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width="500"
height="500"
layout="invalid"
></Image>
<Image
id="invalid-placeholder"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width="500"
height="500"
placeholder="invalid"
Expand Down
25 changes: 14 additions & 11 deletions test/integration/image-component/typescript/pages/valid.tsx
View file
Open in desktop
Expand Up @@ -12,33 +12,33 @@ const Page = () => {
<p>Valid TS</p>
<Image
id="width-and-height-num"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={500}
height={500}
/>
<Image
id="width-and-height-str"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width="500"
height="500"
/>
<div style={{ position: 'relative', width: 100, height: 100 }}>
<Image
id="layout-fill"
src="https://via.placeholder.com/100"
src="https://image-optimization-test.vercel.app/test.jpg"
layout="fill"
/>
</div>
<Image
id="quality-num"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
quality={80}
width={500}
height={500}
/>
<Image
id="quality-str"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
quality="80"
width={500}
height={500}
Expand All @@ -51,21 +51,21 @@ const Page = () => {
/>
<Image
id="object-fit-cover-position-right"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
layout="fill"
objectFit="cover"
objectPosition="right"
/>
<Image
id="object-fit-scale-down-position-50px"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
layout="fill"
objectFit="scale-down"
objectPosition="50px"
/>
<Image
id="placeholder-and-blur-data-url"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={500}
height={500}
placeholder="blur"
Expand All @@ -81,15 +81,18 @@ const Page = () => {
<Image id="object-src-with-avif" src={avif} />
<Image
id="fill-with-unused-width-height"
src="https://via.placeholder.com/200"
src="https://image-optimization-test.vercel.app/test.jpg"
layout="fill"
width={100}
height={100}
/>
<ImageCard id="image-card" src="https://via.placeholder.com/300" />
<ImageCard
id="image-card"
src="https://image-optimization-test.vercel.app/test.jpg"
/>
<DynamicSrcImage
id="dynamic-src"
src="https://via.placeholder.com/400"
src="https://image-optimization-test.vercel.app/test.jpg"
width={400}
height={400}
/>
Expand Down
2 changes: 1 addition & 1 deletion test/integration/image-future/typescript/next.config.js
View file
Open in desktop
@@ -1,6 +1,6 @@
module.exports = {
images: {
domains: ['via.placeholder.com'],
domains: ['image-optimization-test.vercel.app'],
// disableStaticImages: true,
},
experimental: {
Expand Down
4 changes: 2 additions & 2 deletions test/integration/image-future/typescript/pages/invalid.tsx
View file
Open in desktop
Expand Up @@ -8,13 +8,13 @@ const Invalid = () => {
<Image id="invalid-src" src={new Date()} width={500} height={500}></Image>
<Image
id="invalid-width"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={new Date()}
height={500}
></Image>
<Image
id="invalid-placeholder"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width="500"
height="500"
placeholder="invalid"
Expand Down
17 changes: 10 additions & 7 deletions test/integration/image-future/typescript/pages/valid.tsx
View file
Open in desktop
Expand Up @@ -12,26 +12,26 @@ const Page = () => {
<p>Valid TS</p>
<Image
id="width-and-height-num"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={500}
height={500}
/>
<Image
id="width-and-height-str"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width="500"
height="500"
/>
<Image
id="quality-num"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
quality={80}
width={500}
height={500}
/>
<Image
id="quality-str"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
quality="80"
width={500}
height={500}
Expand All @@ -44,7 +44,7 @@ const Page = () => {
/>
<Image
id="placeholder-and-blur-data-url"
src="https://via.placeholder.com/500"
src="https://image-optimization-test.vercel.app/test.jpg"
width={500}
height={500}
placeholder="blur"
Expand All @@ -58,10 +58,13 @@ const Page = () => {
/>
<Image id="object-src-with-svg" src={svg} />
<Image id="object-src-with-avif" src={avif} />
<ImageCard id="image-card" src="https://via.placeholder.com/300" />
<ImageCard
id="image-card"
src="https://image-optimization-test.vercel.app/test.jpg"
/>
<DynamicSrcImage
id="dynamic-src"
src="https://via.placeholder.com/400"
src="https://image-optimization-test.vercel.app/test.jpg"
width={400}
height={400}
/>
Expand Down