Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Build Stats #38884

Merged
merged 11 commits into from Aug 10, 2022
Merged

App Build Stats #38884

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7428967
feat: added app build manifest plugin
wyattjoh Jul 21, 2022
87906c1
fix: ts error
wyattjoh Jul 21, 2022
8d473e2
Rename root -> app
timneutkens Jul 22, 2022
6d95f1b
feat: added new build output template, file info
wyattjoh Jul 26, 2022
034b2cd
fix: some linting, type names
wyattjoh Jul 26, 2022
76678ac
fix: improve size handling, reduced manifest footprint
wyattjoh Jul 27, 2022
e624ac9
chore: remove unused comment
wyattjoh Jul 28, 2022
fbf74bf
review: updated based on review
wyattjoh Aug 9, 2022
93243ed
fix: throw error when manifest can't be read
wyattjoh Aug 10, 2022
d4aeabd
Apply suggestions from code review
ijjk Aug 10, 2022
756f86a
Merge branch 'canary' into feat/app-build-stats
ijjk Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/next/build/entries.ts
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ import {
import {
CLIENT_STATIC_FILES_RUNTIME_AMP,
CLIENT_STATIC_FILES_RUNTIME_MAIN,
CLIENT_STATIC_FILES_RUNTIME_MAIN_ROOT,
CLIENT_STATIC_FILES_RUNTIME_MAIN_APP,
CLIENT_STATIC_FILES_RUNTIME_REACT_REFRESH,
EDGE_RUNTIME_WEBPACK,
} from '../shared/lib/constants'
Expand Down Expand Up @@ -506,14 +506,14 @@ export function finalizeEntrypoint({
// Client special cases
name !== 'polyfills' &&
name !== CLIENT_STATIC_FILES_RUNTIME_MAIN &&
name !== CLIENT_STATIC_FILES_RUNTIME_MAIN_ROOT &&
name !== CLIENT_STATIC_FILES_RUNTIME_MAIN_APP &&
name !== CLIENT_STATIC_FILES_RUNTIME_AMP &&
name !== CLIENT_STATIC_FILES_RUNTIME_REACT_REFRESH
) {
// TODO-APP: this is a temporary fix. @shuding is going to change the handling of server components
if (appDir && entry.import.includes('flight')) {
return {
dependOn: CLIENT_STATIC_FILES_RUNTIME_MAIN_ROOT,
dependOn: CLIENT_STATIC_FILES_RUNTIME_MAIN_APP,
...entry,
}
}
Expand Down