Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @napi-rs/cli devDependency to next-swc #39164

Merged
merged 6 commits into from Jul 30, 2022
Merged

Add missing @napi-rs/cli devDependency to next-swc #39164

merged 6 commits into from Jul 30, 2022

Commits on Jul 29, 2022

  1. Document @napi-rs/cli as required to build Rust code 

    Otherwise build-native fails with "napi: command not found.".

Alternatively, this is missing from this package's devDependencies.
    @Jessidhia
    Jessidhia committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    fd32c32 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. Add @napi-rs/cli as next-swc devDependency, revert contributing.md ch… 

    …ange

It already existed as a dependency but on the "next" package, so it was not in the PATH of "next-swc"'s scripts.
    @Jessidhia
    Jessidhia committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    f57d321 View commit details
    Browse the repository at this point in the history

  2. Ignore Rust build artifacts in prettier 

    It doesn't like the json files that appear in there.
    @Jessidhia
    Jessidhia committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    7121604 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into patch-1

    @ijjk
    ijjk committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    b2ad3fb View commit details
    Browse the repository at this point in the history

  4. match version to CI version

    @ijjk
    ijjk committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    98e93e2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'canary' into patch-1

    @ijjk
    ijjk committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    8ce6faa View commit details
    Browse the repository at this point in the history