Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase proxy limit from 30s to 60s #39814

Closed
wants to merge 1 commit into from

Conversation

abriginets
Copy link

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes #36251

Increasing the limit since original issue wasn't addressed in 4 months. 60_000 value was picked based on default nginx values. See proxy_connect_timeout, proxy_read_timeout and proxy_send_timeout.

@abriginets
Copy link
Author

Ideally this value should be configurable to match any reverse proxy configuration. For now increasing the limit to reduce the amount of errors in people's deployments.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the 30s limit here is intentional to match edge defaults like Vercel, we can add an experimental config like experimental.proxyTimeout to allow configuring this though.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm gonna close this for now per-above, feel free to open a fresh PR with the mentioned experimental config though!

@ijjk ijjk closed this Aug 23, 2022
@bcheidemann
Copy link
Contributor

bcheidemann commented Sep 6, 2022

Hi, the 30s limit here is intentional to match edge defaults like Vercel, we can add an experimental config like experimental.proxyTimeout to allow configuring this though.

@abriginets are you planning to raise a PR for this? If not then I will raise one 😁

@abriginets
Copy link
Author

@abriginets are you planning to raise a PR for this? If not then I will raise one 😁

I'm currently busy with some other work so it would be great if you can open a PR.

@abriginets abriginets deleted the increase-proxy-timeout branch September 6, 2022 12:42
@bcheidemann
Copy link
Contributor

@abriginets are you planning to raise a PR for this? If not then I will raise one 😁

I'm currently busy with some other work so it would be great if you can open a PR.

Thanks for the quick confirmation on this. I will raise a PR later tonight 👍

@bcheidemann
Copy link
Contributor

bcheidemann commented Sep 6, 2022

Hi, the 30s limit here is intentional to match edge defaults like Vercel, we can add an experimental config like experimental.proxyTimeout to allow configuring this though.

I have raised a new PR for adding an experimental config as you suggested @ijjk. See #40289

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next.config.js rewrites] Error: socket hang up
3 participants