Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(with-docker): don't copy package.json twice #39896

Merged
merged 3 commits into from Aug 24, 2022
Merged

chore(with-docker): don't copy package.json twice #39896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d80dc1
chore(with-docker): don't copy package.json twice
boredland Aug 24, 2022
0ebd92a
fix(with-docker): copy next.config.js by default
boredland Aug 24, 2022
fb27465
remove other un-needed copies
ijjk Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/with-docker-compose/next-app/prod.Dockerfile
View file
Open in desktop
Expand Up @@ -42,8 +42,6 @@ RUN adduser --system --uid 1001 nextjs
USER nextjs

COPY --from=builder /app/public ./public
COPY --from=builder /app/next.config.js .
COPY --from=builder /app/package.json .

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
Expand Down
3 changes: 0 additions & 3 deletions examples/with-docker-multi-env/docker/development/Dockerfile
View file
Open in desktop
Expand Up @@ -32,10 +32,7 @@ ENV NODE_ENV=production
RUN addgroup -g 1001 -S nodejs
RUN adduser -S nextjs -u 1001

# You only need to copy next.config.js if you are NOT using the default configuration
# COPY --from=builder /app/next.config.js ./
COPY --from=builder /app/public ./public
COPY --from=builder /app/package.json ./package.json

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
Expand Down
3 changes: 0 additions & 3 deletions examples/with-docker-multi-env/docker/production/Dockerfile
View file
Open in desktop
Expand Up @@ -33,10 +33,7 @@ ENV NODE_ENV=production
RUN addgroup -g 1001 -S nodejs
RUN adduser -S nextjs -u 1001

# You only need to copy next.config.js if you are NOT using the default configuration
# COPY --from=builder /app/next.config.js ./
COPY --from=builder /app/public ./public
COPY --from=builder /app/package.json ./package.json

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
Expand Down
3 changes: 0 additions & 3 deletions examples/with-docker-multi-env/docker/staging/Dockerfile
View file
Open in desktop
Expand Up @@ -33,10 +33,7 @@ ENV NODE_ENV=production
RUN addgroup -g 1001 -S nodejs
RUN adduser -S nextjs -u 1001

# You only need to copy next.config.js if you are NOT using the default configuration
# COPY --from=builder /app/next.config.js ./
COPY --from=builder /app/public ./public
COPY --from=builder /app/package.json ./package.json

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
Expand Down
3 changes: 0 additions & 3 deletions examples/with-docker/Dockerfile
View file
Open in desktop
Expand Up @@ -41,10 +41,7 @@ ENV NODE_ENV production
RUN addgroup --system --gid 1001 nodejs
RUN adduser --system --uid 1001 nextjs

# You only need to copy next.config.js if you are NOT using the default configuration
# COPY --from=builder /app/next.config.js ./
COPY --from=builder /app/public ./public
COPY --from=builder /app/package.json ./package.json

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
Expand Down