Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds note about custom server requirements #39931

Merged
merged 2 commits into from Aug 25, 2022
Merged

Adds note about custom server requirements #39931

merged 2 commits into from Aug 25, 2022

Commits on Aug 25, 2022

  1. Adds note about custom server requirements 

    This wasn't obvious to me when trying out middleware in our project, and the error message was `Invalid URL` - took me embarrassingly long to remember that we run a custom server. Would it be possibly to detect that middleware is used and then throw a descriptive error message when trying to call `next` without `hostname` and `port` in a custom server? If someone can point me to where that could be done, I would be happy to make a pull request.
    @esbenam
    esbenam committed Aug 25, 2022
    Copy the full SHA
    1b9de12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into patch-3

    @ijjk
    ijjk committed Aug 25, 2022
    Copy the full SHA
    d909541 View commit details
    Browse the repository at this point in the history