New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error for ssg and ssr exports from client components in build time #40106
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8eb9e78
Disable ssr and ssg for layout client components
huozhi 84bca3c
only apply to page or layout files
huozhi 27f3c0e
keep the client component checking patch
huozhi b5dbe5b
fix flaky test
huozhi a616d28
lint fix
ijjk bbc55b1
Merge branch 'canary' into build/analysis-gssp
ijjk 9ce7db1
Merge branch 'canary' into build/analysis-gssp
huozhi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 2 additions & 4 deletions
6
test/e2e/app-dir/app/app/client-with-errors/get-server-side-props/page.client.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
export function getServerSideProps() { | ||
return { props: {} } | ||
} | ||
// export function getServerSideProps() { { props: {} } } | ||
|
||
export default function Page() { | ||
return null | ||
return 'client-gssp' | ||
} |
6 changes: 2 additions & 4 deletions
6
test/e2e/app-dir/app/app/client-with-errors/get-static-props/page.client.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
export function getStaticProps() { | ||
return { props: {} } | ||
} | ||
// export function getStaticProps() { return { props: {} }} | ||
|
||
export default function Page() { | ||
return null | ||
return 'client-gsp' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can get the specific line number
getStaticProps
/getServerSideProps
is at it would be nice if we could update the stack for the Error created here so the dev overlay can show the file/codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't get the line number from swc at the moment, so I only give the file path there at least user can search themselves. Will keep this in mind to see if we can optimize it later in the future