Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): do not throw error when extracting examples in Node 18+ #40182

Merged
merged 7 commits into from Sep 5, 2022
Merged

fix(cli): do not throw error when extracting examples in Node 18+ #40182

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82db7a9
fix: swallow `ERR_STREAM_PREMATURE_CLOSE` in Node 18
balazsorban44 Sep 2, 2022
4004ec6
fix Node.js version detection
balazsorban44 Sep 2, 2022
9c97f96
Apply suggestions from code review
balazsorban44 Sep 5, 2022
54d173f
Merge branch 'canary' into fix/issue-39321
kodiakhq[bot] Sep 5, 2022
70b4c77
download tar to tmp folder
balazsorban44 Sep 5, 2022
9fcb153
Merge branch 'fix/issue-39321' of github.com:vercel/next.js into fix/…
balazsorban44 Sep 5, 2022
eeb66d9
remove empty line
balazsorban44 Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/create-next-app/helpers/examples.ts
View file
Open in desktop
Expand Up @@ -79,6 +79,17 @@ export function existsInRepo(nameOrUrl: string): Promise<boolean> {
}
}

// HACK: See: https://github.com/vercel/next.js/issues/39321
balazsorban44 marked this conversation as resolved.
Show resolved Hide resolved
function swallowPrematureStreamClose(e: Error & { code?: string }) {
if (
process.version.startsWith('v18') &&
balazsorban44 marked this conversation as resolved.
Show resolved Hide resolved
e.code === 'ERR_STREAM_PREMATURE_CLOSE'
) {
return
}
throw e
}

export function downloadAndExtractRepo(
root: string,
{ username, name, branch, filePath }: RepoInfo
Expand All @@ -91,7 +102,7 @@ export function downloadAndExtractRepo(
{ cwd: root, strip: filePath ? filePath.split('/').length + 1 : 1 },
[`${name}-${branch.replace(/\//g, '-')}${filePath ? `/${filePath}` : ''}`]
)
)
).catch(swallowPrematureStreamClose)
}

export function downloadAndExtractExample(
Expand All @@ -105,5 +116,5 @@ export function downloadAndExtractExample(
return pipeline(
got.stream('https://codeload.github.com/vercel/next.js/tar.gz/canary'),
tar.extract({ cwd: root, strip: 3 }, [`next.js-canary/examples/${name}`])
)
).catch(swallowPrematureStreamClose)
}