Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scripts comment typos #40207

Merged
merged 2 commits into from Sep 5, 2022
+3 −3
Merged

fix: scripts comment typos #40207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4426d7
fix(typo): numebers -> numbers
hiro0218 Sep 4, 2022
c0096fd
fix(typo): seperated -> separated
hiro0218 Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/trace-dd.mjs
View file
Open in desktop
Expand Up @@ -99,7 +99,7 @@ const collectTraces = async (filePath, metadata) => {
const traces = new Map()
const rootTraces = []

// Input trace file contains newline-seperated sets of traces, where each line is valid JSON
// Input trace file contains newline-separated sets of traces, where each line is valid JSON
// type of Array<TraceEvent>. Read it line-by-line to manually reconstruct trace trees.
//
// We have to read through end of the trace -
Expand Down
4 changes: 2 additions & 2 deletions scripts/trace-to-event-format.mjs
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ const createEvent = (trace, ph, cat) => ({
ph,
// process id. We don't collect this for now, putting arbitrary numbers.
pid: 1,
// thread id. We don't collect this for now, putting arbitrary numebers.
// thread id. We don't collect this for now, putting arbitrary numbers.
tid: 10,
args: trace.tags,
})
Expand Down Expand Up @@ -112,7 +112,7 @@ const collectTraces = async (filePath, outFilePath, metadata) => {
const traces = new Map()
const rootTraces = []

// Input trace file contains newline-seperated sets of traces, where each line is valid JSON
// Input trace file contains newline-separated sets of traces, where each line is valid JSON
// type of Array<TraceEvent>. Read it line-by-line to manually reconstruct trace trees.
//
// We have to read through end of the trace -
Expand Down