Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pagesDirRules when pagesDir is not present #41075

Merged
merged 2 commits into from Sep 30, 2022
Merged

Skip pagesDirRules when pagesDir is not present #41075

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d23c6b
Skip pagesDirRules when pagesDir is not present
huozhi Sep 30, 2022
0eeb9d3
Merge branch 'canary' into fix/lint-rule
kodiakhq[bot] Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/lib/eslint/runLintCheck.ts
View file
Open in desktop
Expand Up @@ -154,7 +154,6 @@ async function lint(

let nextEslintPluginIsEnabled = false
const nextRulesEnabled = new Map<string, Severity>()
const pagesDirRules = ['@next/next/no-html-link-for-pages']

for (const configFile of [eslintrcFile, pkgJsonPath]) {
if (!configFile) continue
Expand Down Expand Up @@ -187,6 +186,7 @@ async function lint(
}

const pagesDir = findPagesDir(baseDir, hasAppDir).pages
const pagesDirRules = pagesDir ? ['@next/next/no-html-link-for-pages'] : []

if (nextEslintPluginIsEnabled) {
let updatedPagesDir = false
Expand Down