Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to incremental migration about dynamic routes + fallbacks #41147

Merged
merged 4 commits into from Oct 4, 2022
Merged

Add note to incremental migration about dynamic routes + fallbacks #41147

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c611a77
Update incremental-adoption.md
leerob Oct 4, 2022
740d26f
Update docs/migrating/incremental-adoption.md
leerob Oct 4, 2022
317f112
Update docs/migrating/incremental-adoption.md
leerob Oct 4, 2022
62eb64a
Merge branch 'canary' into leerob-patch-1
kodiakhq[bot] Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/migrating/incremental-adoption.md
View file
Open in desktop
Expand Up @@ -33,8 +33,6 @@ module.exports = {

To learn more about `basePath`, take a look at our [documentation](/docs/api-reference/next.config.js/basepath.md).

> This feature was introduced in [Next.js 9.5](https://nextjs.org/blog/next-9-5) and up. If you’re using older versions of Next.js, please upgrade before trying it out.

### Rewrites

The second strategy is to create a new Next.js app that points to the root URL of your domain. Then, you can use [`rewrites`](/docs/api-reference/next.config.js/rewrites.md) inside `next.config.js` to have some subpaths to be proxied to your existing app.
Expand Down Expand Up @@ -78,7 +76,7 @@ module.exports = {

To learn more about rewrites, take a look at our [documentation](/docs/api-reference/next.config.js/rewrites.md).

> This feature was introduced in [Next.js 9.5](https://nextjs.org/blog/next-9-5) and up. If you’re using older versions of Next.js, please upgrade before trying it out.
> **Note:** If you are incrementally migrating to a dynamic route (e.g. `[slug].js`) and using `fallback: true` or `fallback: 'blocking'` along with a fallback `rewrite`, ensure you consider the case where pages are not found. When Next.js matches the dynamic route it stops checking any further routes. Using `notFound: true` in `getStaticProps` will return the 404 page without applying the fallback `rewrite`. If this is not desired, you can use `getServerSideProps` with `stale-while-revalidate` Cache-Control headers when returning your props. Then, you can _manually_ proxy to your existing backend using something like [http-proxy](https://github.com/vercel/next.js/discussions/38839#discussioncomment-3744442) instead of returning `notFound: true`.

### Micro-Frontends with Monorepos and Subdomains

Expand Down