Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest experimental react and experimental-edge and unpin test versions #41200

Merged
merged 3 commits into from Oct 5, 2022
Merged

Fix latest experimental react and experimental-edge and unpin test versions #41200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328a47c
unpin experimental react
ijjk Oct 5, 2022
216fec1
this alias breaks react float
gnoff Oct 5, 2022
d0e5bf7
Merge branch 'test/unpin-experimental-react' into stop-aliasing-react…
ijjk Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/next/build/webpack-config.ts
View file
Open in desktop
Expand Up @@ -1217,7 +1217,6 @@ export default async function getBaseWebpackConfig(
'{}',
'./cjs/react-dom-server-legacy.browser.development.js':
'{}',
'react-dom': '{}',
},
handleWebpackExternalForEdgeRuntime,
]
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/app-alias.test.ts
View file
Open in desktop
Expand Up @@ -20,8 +20,8 @@ describe('app-dir alias handling', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app-alias')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/app-edge.test.ts
View file
Open in desktop
Expand Up @@ -20,8 +20,8 @@ describe('app-dir edge SSR', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app-edge')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/app-static.test.ts
View file
Open in desktop
Expand Up @@ -24,8 +24,8 @@ describe('app-dir static/dynamic handling', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app-static')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
})
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/asset-prefix.test.ts
View file
Open in desktop
Expand Up @@ -21,8 +21,8 @@ describe('app-dir assetPrefix handling', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'asset-prefix')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/index.test.ts
View file
Open in desktop
Expand Up @@ -25,8 +25,8 @@ describe('app dir', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/next-font.test.ts
View file
Open in desktop
Expand Up @@ -22,8 +22,8 @@ describe('app dir next-font', () => {
files: new FileRef(path.join(__dirname, 'next-font')),
dependencies: {
'@next/font': 'canary',
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/prefetching.test.ts
View file
Open in desktop
Expand Up @@ -21,8 +21,8 @@ describe('app dir prefetching', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app-prefetch')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/rendering.test.ts
View file
Open in desktop
Expand Up @@ -22,8 +22,8 @@ describe('app dir rendering', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app-rendering')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
})
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/root-layout.test.ts
View file
Open in desktop
Expand Up @@ -27,8 +27,8 @@ describe('app-dir root layout', () => {
),
},
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
})
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/rsc-basic.test.ts
View file
Open in desktop
Expand Up @@ -39,8 +39,8 @@ describe('app dir - react server components', () => {
files: new FileRef(path.join(__dirname, './rsc-basic')),
dependencies: {
'styled-components': '6.0.0-beta.2',
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
packageJson: {
scripts: {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/trailingslash.test.ts
View file
Open in desktop
Expand Up @@ -21,8 +21,8 @@ describe('app-dir trailingSlash handling', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'trailingslash')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/vercel-analytics.test.ts
View file
Open in desktop
Expand Up @@ -23,8 +23,8 @@ describe('vercel analytics', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'app')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
skipStart: true,
env: {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/app-dir/with-babel.test.ts
View file
Open in desktop
Expand Up @@ -20,8 +20,8 @@ describe('with babel', () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'with-babel')),
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
})
})
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/switchable-runtime/index.test.ts
View file
Open in desktop
Expand Up @@ -52,8 +52,8 @@ describe('Switchable runtime', () => {
'next.config.js': new FileRef(join(__dirname, './next.config.js')),
},
dependencies: {
react: '0.0.0-experimental-cb5084d1c-20220924',
'react-dom': '0.0.0-experimental-cb5084d1c-20220924',
react: 'experimental',
'react-dom': 'experimental',
},
})
context = {
Expand Down