Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): relax AppProps to not require generic #41264

Merged
merged 1 commit into from Oct 7, 2022
Merged

fix(ts): relax AppProps to not require generic #41264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/pages/_app.tsx
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ export { NextWebVitalsMetric }

export type AppContext = AppContextType<Router>

export type AppProps<P = {}> = AppPropsType<Router, P>
export type AppProps<P = any> = AppPropsType<Router, P>

/**
* `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
Expand All @@ -31,7 +31,7 @@ async function appGetInitialProps({
return { pageProps }
}

export default class App<P = {}, CP = {}, S = {}> extends React.Component<
export default class App<P = any, CP = {}, S = {}> extends React.Component<
P & AppProps<CP>,
S
> {
Expand Down