Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm to create-next-app environment package manager parser #41279

Merged
merged 10 commits into from Oct 13, 2022
Merged

Add npm to create-next-app environment package manager parser #41279

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
634d2e3
Add npm to environment package parser
Nsttt Oct 8, 2022
6dcd680
Simplify getPkgManager function in create-next-app
Nsttt Oct 9, 2022
3251822
Use custom message based on package manager
Nsttt Oct 9, 2022
de1269e
Merge branch 'canary' into infer-pkg-manager-create-next-app
balazsorban44 Oct 12, 2022
7339a3f
Add tests to create-next-app package manager inference
Nsttt Oct 12, 2022
d54e2e5
Merge branch 'canary' into infer-pkg-manager-create-next-app
balazsorban44 Oct 13, 2022
48ae4d3
Fix try catch check in pnpm usage for create-next-app
Nsttt Oct 13, 2022
f3312d1
Merge branch 'canary' into infer-pkg-manager-create-next-app
balazsorban44 Oct 13, 2022
90d9d1f
Merge branch 'canary' into infer-pkg-manager-create-next-app
ijjk Oct 13, 2022
abffb5d
Merge branch 'canary' into infer-pkg-manager-create-next-app
kodiakhq[bot] Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/create-next-app/helpers/get-pkg-manager.ts
View file
Open in desktop
Expand Up @@ -5,19 +5,19 @@ export type PackageManager = 'npm' | 'pnpm' | 'yarn'
export function getPkgManager(): PackageManager {
try {
const userAgent = process.env.npm_config_user_agent

if (userAgent) {
if (userAgent.startsWith('yarn')) {
execSync('yarn --version', { stdio: 'ignore' })
return 'yarn'
} else if (userAgent.startsWith('pnpm')) {
execSync('pnpm --version', { stdio: 'ignore' })
return 'pnpm'
} else {
return 'npm'
}
}
try {
execSync('yarn --version', { stdio: 'ignore' })
return 'yarn'
} catch {
execSync('pnpm --version', { stdio: 'ignore' })
return 'pnpm'
} else {
return 'npm'
}
} catch {
return 'npm'
Expand Down