Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flakey dev AMP tests #41428

Merged
merged 2 commits into from Oct 14, 2022
Merged

Update flakey dev AMP tests #41428

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c444dfc
Update flakey dev AMP tests
ijjk Oct 14, 2022
ee27085
rename config
ijjk Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/integration/amphtml/test/index.test.js
View file
Open in desktop
Expand Up @@ -313,7 +313,7 @@ describe('AMP Usage', () => {
])
})

it('should detect the changes and display it', async () => {
it.skip('should detect the changes and display it', async () => {
let browser
try {
browser = await webdriver(dynamicAppPort, '/hmr/test')
Expand Down Expand Up @@ -354,7 +354,7 @@ describe('AMP Usage', () => {
}
})

it('should detect changes and refresh an AMP page', async () => {
it.skip('should detect changes and refresh an AMP page', async () => {
let browser
try {
browser = await webdriver(dynamicAppPort, '/hmr/amp')
Expand Down Expand Up @@ -383,7 +383,7 @@ describe('AMP Usage', () => {
}
})

it('should detect changes to component and refresh an AMP page', async () => {
it.skip('should detect changes to component and refresh an AMP page', async () => {
const browser = await webdriver(dynamicAppPort, '/hmr/comp')
await check(() => browser.elementByCss('#hello-comp').text(), /hello/)

Expand All @@ -399,7 +399,7 @@ describe('AMP Usage', () => {
await check(() => browser.elementByCss('#hello-comp').text(), /hello/)
})

it('should not reload unless the page is edited for an AMP page', async () => {
it.skip('should not reload unless the page is edited for an AMP page', async () => {
let browser
const hmrTestPagePath = join(__dirname, '../', 'pages', 'hmr', 'test.js')
const originalContent = readFileSync(hmrTestPagePath, 'utf8')
Expand Down Expand Up @@ -454,7 +454,7 @@ describe('AMP Usage', () => {
}
})

it('should detect changes and refresh a hybrid AMP page', async () => {
it.skip('should detect changes and refresh a hybrid AMP page', async () => {
let browser
try {
browser = await webdriver(dynamicAppPort, '/hmr/hybrid?amp=1')
Expand Down Expand Up @@ -489,7 +489,7 @@ describe('AMP Usage', () => {
}
})

it('should detect changes and refresh an AMP page at root pages/', async () => {
it.skip('should detect changes and refresh an AMP page at root pages/', async () => {
let browser
try {
browser = await webdriver(dynamicAppPort, '/root-hmr')
Expand Down