Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: router.go #41454

Closed
wants to merge 1 commit into from
Closed

feat: router.go #41454

wants to merge 1 commit into from

Conversation

lifeisegg123
Copy link

Feature

Add router.go to implement specific behavior like go back twice.
It can be achieved with window.history.go, but next/router has router.back. Therefore I think it is natural to have go in next/router
fixes: #18333

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

mass2527
mass2527 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@mass2527 mass2527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@balazsorban44
Copy link
Member

balazsorban44 commented Oct 19, 2022 •
edited

Thanks, #41575 just added back() and forward() methods, but for now, I think we wouldn't like to extend this to go(), so I am closing this PR for now. Let's keep the discussion going in the thread you linked to. 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mass2527 mass2527 mass2527 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lifeisegg123 @balazsorban44 @mass2527 @ijjk