Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include frameworks in main-app #41465

Merged
merged 4 commits into from Oct 17, 2022
Merged

Include frameworks in main-app #41465

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e439033
get rid of framework for appdir
shuding Oct 16, 2022
f09f590
Merge branch 'canary' into shu/ea47
shuding Oct 16, 2022
d21d5ff
fix
shuding Oct 16, 2022
d7a08fa
Merge branch 'canary' into shu/ea47
kodiakhq[bot] Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/next/build/webpack-config.ts
View file
Open in desktop
Expand Up @@ -1338,10 +1338,25 @@ export default async function getBaseWebpackConfig(
// and all other chunk depend on them so there is no
// duplication that need to be pulled out.
chunks: (chunk: any) =>
!/^(polyfills|main|pages\/_app)$/.test(chunk.name),
!/^(polyfills|main|main-app|pages\/_app)$/.test(chunk.name),
cacheGroups: {
framework: {
chunks: 'all',
chunks: (chunk) => {
const name = chunk.name

// Skip app directory and include shared modules in main-app.
if (
name &&
hasAppDir &&
(name === 'main-app' ||
name === 'app-internals' ||
name.startsWith('app/'))
) {
return false
}

return true
},
name: 'framework',
test(module: any) {
const resource = module.nameForCondition?.()
Expand Down