Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename more references to "use client" #41467

Closed
wants to merge 1 commit into from

Conversation

sebmarkbage
Copy link
Contributor

I found a number of references to the old "client" directive name. Should these be updated?

@sebmarkbage sebmarkbage changed the title Rename more references to "client" Rename more references to "use client" Oct 17, 2022
@ijjk
Copy link
Member

ijjk commented Oct 17, 2022

Looks like the branch here is behind and these are already updated in latest canary x-ref:

@huozhi
Copy link
Member

huozhi commented Oct 17, 2022

I have updated them in #41333

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huozhi did you do global search and replace?

Just saw your comment above

@sebmarkbage
Copy link
Contributor Author

Hm. Nvm. Something going on with my local branch failing to fetch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants