Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message for appDir feedback #41751

Merged
merged 2 commits into from Oct 24, 2022
Merged

Add message for appDir feedback #41751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
136bfed
Add a feedback message when using `appDir`
javivelasco Oct 24, 2022
0f14389
Move the warning to be an info log
javivelasco Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/next/server/config.ts
View file
Open in desktop
Expand Up @@ -42,6 +42,12 @@ const experimentalWarning = execOnce(
`Experimental features are not covered by semver, and may cause unexpected or broken application behavior. ` +
`Use at your own risk.`
)
if (features.includes('appDir')) {
Log.info(
`Thank you for testing \`appDir\` please leave your feedback at https://nextjs.link/app-feedback`
)
}

console.warn()
}
)
Expand Down
6 changes: 6 additions & 0 deletions test/e2e/app-dir/app-static.test.ts
View file
Open in desktop
Expand Up @@ -348,4 +348,10 @@ describe('app-dir static/dynamic handling', () => {

expect(secondDate).not.toBe(initialDate)
})

it('should show a message to leave feedback for `appDir`', async () => {
expect(next.cliOutput).toContain(
`Thank you for testing \`appDir\` please leave your feedback at https://nextjs.link/app-feedback`
)
})
})