Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prefetch bailout to start of the prefetch function for pages #43731

Merged
merged 4 commits into from Dec 8, 2022
Merged

Move prefetch bailout to start of the prefetch function for pages #43731

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55ea710
Move prefetch bailout to start of the prefetch function for `pages`
timneutkens Dec 5, 2022
46c09ea
Merge branch 'canary' into fix/move-bailout-of-prefetching-in-dev
kodiakhq[bot] Dec 5, 2022
72f35d2
Merge branch 'canary' into fix/move-bailout-of-prefetching-in-dev
ijjk Dec 8, 2022
ad565de
Merge branch 'canary' into fix/move-bailout-of-prefetching-in-dev
kodiakhq[bot] Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/next/shared/lib/router/router.ts
View file
Open in desktop
Expand Up @@ -2263,6 +2263,11 @@ export default class Router implements BaseRouter {
asPath: string = url,
options: PrefetchOptions = {}
): Promise<void> {
// Prefetch is not supported in development mode because it would trigger on-demand-entries
if (process.env.NODE_ENV !== 'production') {
return
}

if (typeof window !== 'undefined' && isBot(window.navigator.userAgent)) {
// No prefetches for bots that render the link since they are typically navigating
// links via the equivalent of a hard navigation and hence never utilize these
Expand Down Expand Up @@ -2357,11 +2362,6 @@ export default class Router implements BaseRouter {
}
}

// Prefetch is not supported in development mode because it would trigger on-demand-entries
if (process.env.NODE_ENV !== 'production') {
return
}

const data =
process.env.__NEXT_MIDDLEWARE_PREFETCH === 'strict'
? ({} as any)
Expand Down