Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #43828

Merged
merged 2 commits into from Dec 8, 2022
Merged

Refactor code #43828

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d2f636
refactor code
shuding Dec 7, 2022
98f2e31
Merge branch 'canary' into shu/2lqy
shuding Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/next/server/dev/hot-reloader.ts
View file
Open in desktop
Expand Up @@ -766,7 +766,7 @@ export default class HotReloader {
(
pageHashMap: Map<string, string>,
changedItems: Set<string>,
serverComponentChangeCallback?: (key: string) => void
serverComponentChangedItems?: Set<string>
) =>
(stats: webpack.Compilation) => {
try {
Expand Down Expand Up @@ -849,12 +849,12 @@ export default class HotReloader {
}
pageHashMap.set(key, curHash)

if (serverComponentChangeCallback) {
if (serverComponentChangedItems) {
const serverKey = WEBPACK_LAYERS.server + ':' + key
const prevServerHash = pageHashMap.get(serverKey)
const curServerHash = chunksHashServerLayer.toString()
if (prevServerHash && prevServerHash !== curServerHash) {
serverComponentChangeCallback(key)
serverComponentChangedItems.add(key)
}
pageHashMap.set(serverKey, curServerHash)
}
Expand All @@ -877,16 +877,18 @@ export default class HotReloader {
)
this.multiCompiler.compilers[1].hooks.emit.tap(
'NextjsHotReloaderForServer',
trackPageChanges(prevServerPageHashes, changedServerPages, (key) =>
changedServerComponentPages.add(key)
trackPageChanges(
prevServerPageHashes,
changedServerPages,
changedServerComponentPages
)
)
this.multiCompiler.compilers[2].hooks.emit.tap(
'NextjsHotReloaderForServer',
trackPageChanges(
prevEdgeServerPageHashes,
changedEdgeServerPages,
(key) => changedServerComponentPages.add(key)
changedServerComponentPages
)
)

Expand Down