Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for query params on not found pages #43836

Merged
merged 7 commits into from Dec 13, 2022
Merged

Added support for query params on not found pages #43836

merged 7 commits into from Dec 13, 2022
+352 −100

Commits on Dec 12, 2022

  1. fix: added support for query params on 404 page 

    Previously, query parameters were not available on 404 pages because
calling the router methods would change the pathname in the browser.
This change adds support for the query to update for those pages
without updating the path to include the basePath.
    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    da56bec View commit details
    Browse the repository at this point in the history

  2. fix: fixed tests, support /_error

    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    09d3db5 View commit details
    Browse the repository at this point in the history

  3. fix: linting

    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    cd56f0d View commit details
    Browse the repository at this point in the history

  4. fix: handle hydration case for SSR { notFound: true }

    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    059925f View commit details
    Browse the repository at this point in the history

  5. fix: ensure status code is respected

    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    cf7c843 View commit details
    Browse the repository at this point in the history

  6. fix: linting

    @wyattjoh
    wyattjoh committed Dec 12, 2022
    Copy the full SHA
    2466a90 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'canary' into wyattjoh/not-found-pages-router-support

    @ijjk
    ijjk committed Dec 12, 2022
    Copy the full SHA
    9b3e93c View commit details
    Browse the repository at this point in the history