Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify with-google-analytics example #43894

Merged
merged 16 commits into from Feb 7, 2023
Merged

Simplify with-google-analytics example #43894

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4854604
Remove unnecesary file
Josehower Dec 9, 2022
bc4f914
Remove unnecesary code for the example
Josehower Dec 9, 2022
6dbcf1a
Move back event since is necessary
Josehower Dec 9, 2022
0e504e3
Remove hashChangeComplete event
Josehower Dec 9, 2022
a324e70
Reorder imports
Josehower Dec 9, 2022
9e1769f
Move back code style
Josehower Dec 9, 2022
7aa3e46
Merge branch 'remove-unnecesary-id' into remove-unnecesary-document-file
Josehower Dec 10, 2022
d7138c0
Solve webVitals issue with no _document.js
Josehower Dec 12, 2022
0268324
Move the comment to the right place
Josehower Dec 12, 2022
581c0af
Remove configuration that was not in example
Josehower Dec 12, 2022
cab512e
Move back code styles
Josehower Dec 12, 2022
4ce3056
Run prettier
Josehower Dec 12, 2022
29b9945
Merge branch 'canary' into remove-unnecesary-document-file
Josehower Dec 16, 2022
eef2106
Remove semicolon
Josehower Dec 16, 2022
347db20
Fix indentation
Josehower Dec 16, 2022
a19eea2
Merge branch 'canary' into remove-unnecesary-document-file
ijjk Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 17 additions & 12 deletions examples/with-google-analytics/pages/_app.js
View file
Open in desktop
@@ -1,7 +1,8 @@
import { useEffect } from 'react'
import Script from 'next/script'
import { useRouter } from 'next/router'
import * as gtag from '../lib/gtag'
import { useEffect } from 'react';
import Script from 'next/script';
import Head from 'next/head';
import { useRouter } from 'next/router';
import * as gtag from '../lib/gtag';

const App = ({ Component, pageProps }) => {
const router = useRouter()
Expand All @@ -17,27 +18,31 @@ const App = ({ Component, pageProps }) => {

return (
<>
<Head>
{/* Global Site Tag (gtag.js) - Google Analytics */}
<Script
strategy="afterInteractive"
src={`https://www.googletagmanager.com/gtag/js?id=${gtag.GA_TRACKING_ID}`}
/>
<Script
strategy="afterInteractive"
<script
dangerouslySetInnerHTML={{
__html: `
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());

// Disable any default-enabled advertising features (turn them on later when we get consent)
gtag('set', 'allow_google_signals', false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we shouldn't add this in the PR:

  • It is not required to set up Google Analytics
  • Anyone who follows Google Analytics' instruction can add this easily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of the PR anymore. ill update the description, sorry for that

Copy link
Contributor Author

@Josehower Josehower Dec 16, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vercel/next.js/pull/43894/files

maybe you are looking to an old version of the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit that removes this code 4 days ago

581c0af


gtag('config', '${gtag.GA_TRACKING_ID}', {
page_path: window.location.pathname,
});
`,
}}
/>
<Component {...pageProps} />
</>
</Head>
<Script
strategy="afterInteractive"
src={`https://www.googletagmanager.com/gtag/js?id=${gtag.GA_TRACKING_ID}`}
/>
<Component {...pageProps} />;
</>
)
}

Expand Down