Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ReactRefreshLogBox scss test #44180

Merged
merged 1 commit into from Dec 20, 2022
Merged

Enable ReactRefreshLogBox scss test #44180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts
View file
Open in desktop
Expand Up @@ -4,9 +4,7 @@ import { createNext, FileRef } from 'e2e-utils'
import { NextInstance } from 'test/lib/next-modes/base'
import path from 'path'

// TODO: figure out why snapshots mismatch on GitHub actions
// specifically but work in docker and locally
describe.skip('ReactRefreshLogBox app', () => {
describe('ReactRefreshLogBox app', () => {
let next: NextInstance

beforeAll(async () => {
Expand Down Expand Up @@ -48,6 +46,10 @@ describe.skip('ReactRefreshLogBox app', () => {
const source = await session.getRedboxSource()
expect(source).toMatchSnapshot()

// Fix syntax error
await session.patch('index.module.scss', `.button { font-size: 5px; }`)
expect(await session.hasRedbox()).toBe(false)

// Not local error
await session.patch('index.module.scss', `button { font-size: 5px; }`)
expect(await session.hasRedbox(true)).toBe(true)
Expand Down
19 changes: 19 additions & 0 deletions test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-scss.test.ts.snap
View file
Open in desktop
@@ -0,0 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ReactRefreshLogBox app scss syntax errors 1`] = `
"./index.module.scss
SassError: Expected expression.
╷
1 │ .button { font-size: :5px; }
│ ^
╵
index.module.scss 1:22 root stylesheet"
`;

exports[`ReactRefreshLogBox app scss syntax errors 2`] = `
"./index.module.scss:1:1
Syntax error: Selector \\"button\\" is not pure (pure selectors must contain at least one local class or id)

> 1 | button { font-size: 5px; }
| ^"
`;