Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected object mutation while resolving Open Graph #49514

Merged
merged 5 commits into from
May 10, 2023
Merged

Fix unexpected object mutation while resolving Open Graph #49514

merged 5 commits into from
May 10, 2023

Commits on May 9, 2023

  1. Fix unexpected object mutation while resolving Open Graph 

    Modifying an object passed from external sources can unintentionally lead to unpredictable behavior.

By changing the implementation from in-place object modification to returning a new object, we can make the method more predictable.

fixes vercel#49501
    @runjuu
    runjuu committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a182f79 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @huozhi
    huozhi committed May 9, 2023
    Configuration menu
    Copy the full SHA
    19c33dc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into canary

    @huozhi
    huozhi committed May 9, 2023
    Configuration menu
    Copy the full SHA
    20bd861 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'canary' into canary

    @huozhi
    huozhi committed May 9, 2023
    Configuration menu
    Copy the full SHA
    875208b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'canary' into canary

    @sokra
    sokra committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0fd4944 View commit details
    Browse the repository at this point in the history