Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Standalone node http server starts accepting requests before next handler is ready #49548

Merged
merged 5 commits into from
May 11, 2023
Merged

fix: Standalone node http server starts accepting requests before next handler is ready #49548

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c77bb6
fix: Next server handler not ready when node http server starts accep…
ferdingler May 9, 2023
cee4c78
Merge branch 'canary' into canary
ferdingler May 10, 2023
8c654d4
Merge branch 'canary' into canary
timneutkens May 11, 2023
ee7f42e
Merge branch 'canary' into canary
ijjk May 11, 2023
f02b1a5
Apply suggestions from code review
ijjk May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
74 changes: 38 additions & 36 deletions packages/next/src/build/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,8 +1939,6 @@ if (!process.env.NEXT_MANUAL_SIG_HANDLE) {
process.on('SIGINT', () => process.exit(0))
}

let handler

const currentPort = parseInt(process.env.PORT, 10) || 3000
const hostname = process.env.HOSTNAME || 'localhost'
const keepAliveTimeout = parseInt(process.env.KEEP_ALIVE_TIMEOUT, 10);
Expand All @@ -1951,42 +1949,46 @@ const nextConfig = ${JSON.stringify({

process.env.__NEXT_PRIVATE_STANDALONE_CONFIG = JSON.stringify(nextConfig)

const server = http.createServer(async (req, res) => {
try {
await handler(req, res)
} catch (err) {
console.error(err);
res.statusCode = 500
res.end('Internal Server Error')
}
})

if (
!Number.isNaN(keepAliveTimeout) &&
Number.isFinite(keepAliveTimeout) &&
keepAliveTimeout >= 0
) {
server.keepAliveTimeout = keepAliveTimeout
}
server.listen(currentPort, async (err) => {
if (err) {
console.error("Failed to start server", err)
process.exit(1)
}

handler = await createServerHandler({
port: currentPort,
hostname,
dir,
conf: nextConfig,
createServerHandler({
port: currentPort,
hostname,
dir,
conf: nextConfig,
}).then((nextHandler) => {
const server = http.createServer(async (req, res) => {
try {
await nextHandler(req, res)
} catch (err) {
console.error(err);
res.statusCode = 500
res.end('Internal Server Error')
}
})

if (
!Number.isNaN(keepAliveTimeout) &&
Number.isFinite(keepAliveTimeout) &&
keepAliveTimeout >= 0
) {
server.keepAliveTimeout = keepAliveTimeout
}
server.listen(currentPort, async (err) => {
if (err) {
console.error("Failed to start server", err)
process.exit(1)
}

console.log(
'Listening on port',
currentPort,
'url: http://' + hostname + ':' + currentPort
)
});

console.log(
'Listening on port',
currentPort,
'url: http://' + hostname + ':' + currentPort
)
})`
}).catch(err => {
console.error(err);
process.exit(1);
});`
)
}

Expand Down